v4.1.x: Bull 2020 update of coll/han #8487
Conversation
|
Can one of the admins verify this patch? |
|
ok to test |
|
Is there anything I can do to help reviewers to progress on this PR ? |
|
You should request the reviewers that reviewed the PR in master. |
Thanks, indeed it would be great to have @jsquyres (who reviewed previous attempt #8437) or @ggouaillardet (who merged master equivalent #8462) reviewing / merging this PR ;) |
|
I just made a few comments about fixing on master first and then cherry-picking to release branches. 😉 HAN is from @bosilca, so I defer to his review! |
|
I would have preferred this to be separate commits as there are mutually exclusive fixes and updates in the commit, but given this is a cherry-pick from master it is fine to leave it as is. Can you amend your one-line commit summary to be a bit more descriptive of the change? Bull update of coll/han doesn't really indicate what the change is :) |
…ygen and some fixes This completes and fixes current code for coll/Han: - a barrier is added - a "simple" scatter is added - some Doxygen documentation is added Fix: - compilation and cppcheck warnings - corner case errors when parsing a rule file Signed-off-by: Emmanuel Brelle <[email protected]> (cherry picked from commit ca663de)
EmmanuelBRELLE
force-pushed
the
v4.1.x_Bull_2020_update_for_Han
branch
from
508e283 to
feadc68
Compare
You are right, I should have splitted the commit for each feature, I apology. That makes the one-line commit message difficult to write and complexify any revert. I tried (in feadc68) to improve the one-line message, but someone who wants details will look at the full commit message, at the end. |
This completes and fixes current code for coll/Han:
Fix:
Signed-off-by: Emmanuel Brelle [email protected]
(cherry picked from commit ca663de)
This is the re-submission of PR #8437 (on v4.1x), now that PR #8462 is merged on master.